minecraft/protocol: Fix the marshal of debug drawer packet #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didntpot
suggested changes
Nov 4, 2025
Collaborator
|
This all looks good! Have you tested spawning in all the shapes to make sure they work? |
Contributor
Author
Yes, all the things (or say, the modifications) is based on what I saw in the game, this time I have not use IDA anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For possible references, please refer to DebugDrawerPacket.json.
But unfortunately, the official documentation (DebugDrawerPacket.html) does not provide a complete description of it.
Even DebugDrawerPacket.json itself is incomplete.
I controlled the variable a great many times in Minecraft and finally fixed this packet.
Good luck to me, this time I didn't use IDA, which reduced the mental torture it caused me.