add disconnect reason constants #333
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didntpot
reviewed
Aug 12, 2025
Collaborator
|
Are these up to date as of 1.21.100? |
| type Disconnect struct { | ||
| // Reason is the reason for the disconnection. It seems as if this field has no use other than for | ||
| // telemetry reasons as it does not affect the message that gets displayed on the disconnect screen. | ||
| // Reason is the reason for the disconnection. This affects the error code displayed on the Ore UI disconnection screen and is one of the constants above. |
Collaborator
There was a problem hiding this comment.
- // Reason is the reason for the disconnection. This affects the error code displayed on the Ore UI disconnection screen and is one of the constants above.
+ // Reason is the reason for the disconnection. This affects the error code displayed on the Ore UI
+ // disconnection screen and is one of the constants above.
Contributor
|
DiscoveryEnvironmentMismatch, HostWithoutKeys were added in 1.21.120 |
Sandertv
approved these changes
Oct 29, 2025
Sandertv
requested changes
Oct 29, 2025
Owner
Sandertv
left a comment
There was a problem hiding this comment.
Pending newly added disconnect reasons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used in the oreui disconnect screen in 1.21.100