Use microsoft server time in signed requests #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwistedAsylumMC
requested changes
Oct 23, 2025
minecraft/auth/live.go
Outdated
Comment on lines
103
to
107
| serverDateMu sync.Mutex | ||
| // serverDate represents the most recent server date received from Microsoft servers. | ||
| // It's used for the signed requests which can be blocked if the users device time is not synced. | ||
| // It uses the date received from the unsigned requests. | ||
| serverDate time.Time |
Collaborator
There was a problem hiding this comment.
Bit of a nitpick, but would "server time" be a better way to describe this, since in Go it's called a time.Time compared to a Date in javascript etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SImply saving serverTime to a variable works because Token() is always called during the dial process before sending the signed requests obtainXblToken and obtainDeviceToken