Disable basic auth in Grafana and support graceful shutdown #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, configured with basic auth, in front of Grafana
Contributor
Author
|
This fixes so that it's possible to put a basic auth configured reverse proxy in front of Grafana by disabling basic auth support in Grafana (which will receive the Authentication headers sent to the reverse proxy, and then respond with an authentication denied response unless basic.auth is disabled). This pull request also includes the fix suggested in #16 so that graceful shutdown works. Sorry for not making two separate pull requests. The commits can be cherry-picked if desired. |
Owner
|
sure seems good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #16