这是indexloc提供的服务,不要输入任何密码
Skip to content

Add support for playback speed in PillarboxCastPlayer #983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2025

Conversation

MGaetan89
Copy link
Member

Description

This PR adds support for setting the playback speed to a PillarboxCastPlayer.

Changes made

  • Add support for setting the playback parameters in PillarboxCastPlayer, in particular to handle playback speed (the pitch value is ignored).
  • Add support for setting the playlist metadata in PillarboxCastPlayer (see the corresponding Media3 PR).
  • Remove the Pull request title from the Pull Request template, since its redundant.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@MGaetan89 MGaetan89 self-assigned this Apr 11, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Pillarbox Apr 11, 2025
@MGaetan89 MGaetan89 linked an issue Apr 11, 2025 that may be closed by this pull request
1 task
Copy link

github-actions bot commented Apr 11, 2025

Code Coverage

Overall Project 48.24% -0.19% 🟢
Files changed 3.13% 🟢

Module Coverage
:pillarbox-cast 5.63% -2.29% 🟢
Files
Module File Coverage
:pillarbox-cast PillarboxCastPlayer.kt 3.38% -3.17% 🟢

@MGaetan89 MGaetan89 requested a review from StaehliJ April 11, 2025 06:53
@MGaetan89 MGaetan89 merged commit 1fdff50 into 928-custom-castplayer Apr 14, 2025
9 of 10 checks passed
@MGaetan89 MGaetan89 deleted the 980-handle-playback-speed branch April 14, 2025 08:58
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Pillarbox Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Handle playback speed
2 participants