Coord rewrite #975
Merged
Coord rewrite #975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The Ubuntu instructions need Did only some minor testing and encountered this error The gathering area for resources is offset too much to the left. Happens when harvesting gold, wood, stone. Sheep are affected too I think, but it was hard to see. |
a9519c8 to
f5e299e
Compare
Member
Author
|
Fixed by removing a workaround that was there due to a bug in the old coord system. |
zuntrax
approved these changes
Feb 18, 2018
Contributor
zuntrax
left a comment
There was a problem hiding this comment.
Didn't read everything in detail, but code is definitely better than before and most stuff seems to work. If something breaks, we can still fix it later.
This was referenced Feb 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally, here's the working version of openage with the new coordinate system.
Please test if things work as desired.
This is a long awaited dependency for #850.
Closes #662 (which is @mic-e's pull for this).