Text renderer with support for colors #357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libopenage/engine.cpp
Outdated
Member
There was a problem hiding this comment.
this->text_renderer = std::make_unique<renderer::TextRenderer>()
Member
|
Nice work! We can merge it soon, i'll integrate it into #287 then but it is functional standalone. |
85843eb to
ed6726e
Compare
libopenage/renderer/text_renderer.h
Outdated
Member
There was a problem hiding this comment.
One small thing left: struct names are lowercase-underscored. text_render_batch and text_render_batch_pass.
Would also be nice if you added some /** documentation */ for the members of this class.
2286e28 to
c1511db
Compare
Contributor
Author
|
Completed the required changes. |
TheJJ
added a commit
that referenced
this pull request
Aug 23, 2015
text renderer with support for colors
Member
|
Thanks! Cool stuff. |
mirelon
pushed a commit
to mirelon/openage
that referenced
this pull request
Jan 15, 2016
text renderer with support for colors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.