-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Coordinate types pretty print #1636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
TheJJ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
maybe we can split this into multiple files already
7f3d4d8 to
3b13d76
Compare
|
@TheJJ Wouldn't this require switching away from the decorator method? I would like to keep that for now, since it makes adding new printers pretty easy. |
3b13d76 to
d46f0d4
Compare
d46f0d4 to
b92138d
Compare
|
the decorator can be imported like any regular function, no? |
|
@TheJJ Yes, but to use the decorator, the module with the classes would have to be imported too. And somehow, gdb doesn't seem to like that. At least I get errors when I try that for the .gdbinit file but gdb doesn't print the exact issue. I'm not sure how to solve this yet, so having the printers all in one file is the best solution right now. |
TheJJ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe leave a note in the cpp code to remember to update the pretty printer when changing it :)
|
@TheJJ Done :) |
625dab4 to
0aa78a0
Compare
0aa78a0 to
d79640e
Compare
|
Now it should be good to merge, finally |
Depends on #1633
This just flattens the parent hierarchy to make the parent invisible and directly show the coordinate values.