Add atan2 to FixedPoint
#1587
Merged
Add atan2 to FixedPoint
#1587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heinezen
approved these changes
Oct 22, 2023
Member
heinezen
left a comment
There was a problem hiding this comment.
Thank you, although this doesn't address the intention of the original issue. The purpose of #1543 is to completely remove all floating point calculations in-between, so it's always deterministic. This includes the use of std:: functions.
heinezen
requested changes
Oct 22, 2023
Member
heinezen
left a comment
There was a problem hiding this comment.
You need to change the copyright year for fixed_point_test.cpp (see the CI output)
heinezen
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
atan2as a member function toFixedPointatan2function forFixedPointin std namepaceatan2