Nice!

Ok, so added an image placeholder (and formated better the info), but I am not sure from where to fetch the icons (is this even in?), anyone knows? In any case, we can leave the placeholder until nyan.

@MaanooAk Really cool stuff! Just asking: Is there any issue with the ui-label that could be referenced here or is maybe even already fixed by this PR/ or in general outdated?

@simonsan I fixed the #611, the others are mostly suggestions and not bugs.

@simonsan I fixed the #611, the others are mostly suggestions and not bugs.

Nice, thank you for taking a look into that. 👍

@MaanooAk The icons are in assets/converted/interface/50730.slp.png, but not cut out. I wouldn't worry about that until #1151 is ready.

@heinezen Ok, at the moment a have the placeholder with image://by-filename/converted/interface/50730.slp.png.2, so they are somehow cut but the mapping of sprite location to unit type is probably missing. However #1151 should keep in mind that icons are needed

There are two slp/shp files you probably want to reference there eventually. btnunit.shp (50730) is for units, and ico_bld2.shp (50706, but there's 4 identical ones, iirc) is for buildings.

Eventually you probably want itemicon.shp (50731) as well, those are the icons for the amount of wood carried, armor, attack range etc.

The progress bar is in sundial.shp (50764), and if you want to make it really identical you should get unithalo.shp (53003) as well, to display behind the unit icon.

The correct icon you get from the dat file, in genieutils it is Unit::IconID, which is the frame number in the SLP/SHP file.

References, in case I missed something (it's some time since I implemented it); https://github.com/sandsmark/freeaoe/blob/master/src/ui/UnitInfoPanel.cpp is the info panel itself, and here I collected all the filenames with IDs I've found; https://github.com/sandsmark/freeaoe/blob/master/src/resource/AssetManager.cpp#L400-L620 (and excuse the messy code it isn't really meant to be read by others, but you can see the files I load for what I hope)

@sandsmark HUGE help, thanks mate

Made the icon to be exported to the unit type and then made the gui actually showing the correct icon (and added the border from 53003.slp). And also added the team tag (Enemy, Ally or nothing) bellow the name and civ)

I think this is a good point for merge (progress and health bars next month...)

@MaanooAk Looks fine :)

Keep in mind that a lot of the changes could become obsolete with the new nyan gamestate, so you might want to look out for that.