Enhanced singlefile conversion and support for DE1 formats #1148
Conversation
21baf88 to
a3ec958
Compare
| """ | ||
| return determine_rgba_matrix(self.pcolor, palette, player_number) | ||
| # fetch drawing instruction | ||
| cmd = self.get_byte_at(dpos) |
There was a problem hiding this comment.
we have to make sure this is properly resolved to a c++-only call. we can see that in the cythonized html file. otherwise this will really slow down the conversion.
There was a problem hiding this comment.
Wouldn't the function declaration with cdef ensure that?
| cdef class SMPOutlineFrame(SMPFrame): | ||
| """ | ||
| SMPFrame for the outline graphics. | ||
| """ |
There was a problem hiding this comment.
hm, i wonder why they are doing that. in any way, if the outline information is separate from the graphics info, we have to merge them in order to do our alpha-encoding.
There was a problem hiding this comment.
Probably because they wanted a smaller number of commands (?) Or something to do with their expanded rendering. Merging should work fine, since he outlines does not overlay with any other pixels in the main graphic.
| subtex = TextureImage( | ||
| frame.get_picture_data(palette, self.player_id), | ||
| frame.get_picture_data(main_palette, player_palette), |
There was a problem hiding this comment.
here we have to do the merging of the outline info and the graphics i think.
what do we do about the damage graphics? (we should likely discuss that in the chat :)
Adds more options to the "singlefile" conversion to support newer game versions and SLPs outside of DRS archives. Specifically: