Installation improvements #723
Conversation
77fab4c to
92906b0
Compare
f776e0e to
72c628c
Compare
a0eb469 to
40ba5cc
Compare
1bb36da to
fda12d8
Compare
Tomatower
left a comment
There was a problem hiding this comment.
Found some plain-old-C stuff that should be easy fixing and not copying data on lioad
libopenage/util/csv.h
Outdated
| if (unlikely(strbuf.size() <= line.size())) { | ||
| strbuf.resize(line.size() + 1); | ||
| } | ||
| memcpy(strbuf.data(), line.c_str(), line.size() + 1); |
There was a problem hiding this comment.
Why memcpy here?
std::copy(line.c_str(), line.c_str()+line.size(), std::back_inserter(strbuf));
libopenage/util/csv.h
Outdated
| if (unlikely(strbuf.size() <= line.size())) { | ||
| strbuf.resize(line.size() + 1); | ||
| } | ||
| memcpy(strbuf.data(), line.c_str(), line.size() + 1); |
libopenage/util/csv.h
Outdated
| memcpy(strbuf.data(), line.c_str(), line.size() + 1); | ||
|
|
||
| // use the line copy to fill the current line struct. | ||
| int error_column = current_line_data.fill(strbuf.data()); |
There was a problem hiding this comment.
Actually - Why not give the line.data() directly into the fill() method?
There was a problem hiding this comment.
because the fill method will modify the data, and i think that line.c_str() is const.
There was a problem hiding this comment.
Why does the fill method modify the data? strbuf is rewritten for every line
There was a problem hiding this comment.
It was based on strtok once, not sure if it still does.
There was a problem hiding this comment.
Ah now I see what you mean... It is finally consumed here - and there write access is required - which is still not completely broken - if the string is not modified in length one can use &line[0] - and continue to avoid any copy
libopenage/util/csv.h
Outdated
| memcpy(strbuf.data(), line.c_str(), line.size() + 1); | ||
|
|
||
| // use the line copy to fill the current line struct. | ||
| int error_column = current_line_data.fill(strbuf.data()); |
There was a problem hiding this comment.
same here - use line.data() or
|
I'll clean the whole csv reading up, it's really a mess... |
|
Hello everyone, I am liking this project but... why use docx instead of a more documented and libre option as .odt? thanks in advance. |
|
If I remember correctly the .docx files are in fact csv files. |
|
@jonaspm, in other words: it's not that docx. |
|
This file suffix is purely a troll, in fact the files are just plain text. We wanted to use them as as "temporary solution" until we have nyan, but this turned out to be way more complicated, so we still have them as of today, but they will go away at least after my master thesis about nyan. 😛 |
this preserves the union but may slow things down a bit
pythontex.py(fixes blacklist pythontex in the buildsystem #708)devmode/usr/share,/home,--assets, ...)std::istream,std::getlineetcutil::Pathall over the codebase.call()method for python objectsworks towards #691