Hmm, i think that's too dirty 😉, playing the actual assigned destruction sounds should be implemented right away, not some hardcoded number.

<vortigaunt voice> agreed. the free man must hurry. </vortigaunt voice>

oh! we have the actual id for each building? into teh codez!

On the game, you click a TerrainObject, which knows only the texture and foundation_size from the TestBuilding (which has the sound). At this time, should we put effort into giving to TerrainObject more info about the building, or the hardcoded option is good enough for this demo game_main.cpp?

put it into the game_main.cpp for now, we have to generalize the sounds for all units and not just buildings anyway soon.

okay!

in the future we want Jon0's horse can walk through the town center, so we should have a building layer and an unit layer or something like that. and maybe each layer should just be pointers to entities in the game? i don't know if this is the time to discuss this :p

/**
terrain object class represents one immobile object on the map (building, trees, fish, ...).
*/

a tree is a building? a fish is a building?

should we add a dying_sound to terrainobject, or it'd be enough to add a 'building_id'?

EDIT: whoops, wanted to cancel this comment and closed the whole thing, reopened

This inheritance equals the original game data, as seen in https://github.com/SFTtech/openage/blob/master/py/openage/convert/gamedata/unit.py#L933

@jamesmintram is currently implementing the new renderer, when that is done, we can look into multilayer buildings (see #58).

The "quick" fix would be a dying sound for TerrainObjects. In the long run, we'll have GameObjects and the TerrainObjects inherits from it.

done TheJJ "quick" fix and somehow it doesn't work!

aha! all dying sounds are -1! anyone can reproduce or my assets are different (spanish version)?

i have a similar issue with #59, where most creation0 and creation1 are -1

#108 tries to fix both placement and destruction sounds