Fix several errors #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change default source name to "nuget.org". Properly initialize options for https.get. Always log request URL.
Rebel028
reviewed
Jul 1, 2021
Owner
|
Thanks for contributing @mpolicki New version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actions/checkout@v2is necessary because withv1, pushing the newly created tag failed withfatal: could not read Username for 'https://github.com': No such device or address.The default source name should be
nuget.orgbecausehttps://api.nuget.org/v3/index.jsonseems to be available by default under the namenuget.org. Previously, the code checked whether the provided source (defaultapi.nuget.org) was in existing sources, and if it was, assumed that it was under the namedefault, which didn't work.optionshas to be initialized to{ }becausehttps.getfails silently otherwise, which is what was happening in the non-GPR case.URL logging should happen for both GPR and non-GPR.