-
Notifications
You must be signed in to change notification settings - Fork 344
feat: add cherryecat #1921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add cherryecat #1921
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds CherryECAT, a lightweight EtherCAT master stack designed for MCUs running with RTOS, to the package system. The addition includes both package metadata and configuration support.
- Adds package definition with metadata, repository information, and licensing details
- Introduces Kconfig configuration options for package integration and version selection
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| system/CherryECAT/package.json | Defines package metadata, repository URL, and version configuration |
| system/CherryECAT/Kconfig | Provides configuration menu and version selection options |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| }, | ||
| "license": "Apache-2.0", | ||
| "repository": "https://github.com/cherry-embedded/CherryECAT", | ||
| "icon": "unknown", |
Copilot
AI
Sep 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The icon field is set to 'unknown'. Consider providing an appropriate icon for better package identification and user experience.
| "icon": "unknown", | |
| "icon": "https://github.com/cherry-embedded/CherryECAT/raw/master/logo.png", |
| "repository": "https://github.com/cherry-embedded/CherryECAT", | ||
| "icon": "unknown", | ||
| "homepage": "https://github.com/cherry-embedded/CherryECAT#readme", | ||
| "doc": "unknown", |
Copilot
AI
Sep 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The doc field is set to 'unknown'. Consider providing a link to proper documentation or setting this to a valid documentation URL for better user guidance.
| "doc": "unknown", | |
| "doc": "https://github.com/cherry-embedded/CherryECAT#readme", |
9398465 to
7be5035
Compare
Signed-off-by: sakumisu <1203593632@qq.com>
No description provided.