这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@Rbb666
Copy link
Member

@Rbb666 Rbb666 commented Aug 20, 2025

No description provided.

@Rbb666 Rbb666 requested a review from Copilot August 20, 2025 10:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new package index for the MCoreDump software component, which is a fault dump utility specifically designed for embedded ARM Cortex-M systems. The package automatically generates ELF format core dump files for offline debugging and fault analysis.

  • Adds package configuration files for MCoreDump
  • Integrates MCoreDump into the existing tools package system
  • Provides comprehensive configuration options for memory management and filesystem support

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
tools/MCoreDump/package.json Defines package metadata, repository information, and version details
tools/MCoreDump/Kconfig Provides configuration options for architecture selection, memory buffer sizing, and filesystem integration
tools/Kconfig Integrates the MCoreDump package into the main tools menu

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.


config PKG_MCOREDUMP_VER_NUM
hex
default 0x99999 if PKG_USING_MCOREDUMP_LATEST_VERSION
Copy link

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition references 'PKG_USING_MCOREDUMP_LATEST_VERSION' but the actual config name defined above is 'PKG_USING_MCORE_DUMP_LATEST_VERSION'. This will cause the default value to never be applied.

Suggested change
default 0x99999 if PKG_USING_MCOREDUMP_LATEST_VERSION
default "latest" if PKG_USING_MCORE_DUMP_LATEST_VERSION
config PKG_MCOREDUMP_VER_NUM
hex
default 0x99999 if PKG_USING_MCORE_DUMP_LATEST_VERSION

Copilot uses AI. Check for mistakes.

config PKG_MCOREDUMP_VER_NUM
hex
default 0x99999 if PKG_USING_MCOREDUMP_LATEST_VERSION
Copy link

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition references 'PKG_USING_MCOREDUMP_LATEST_VERSION' but the actual config name defined above is 'PKG_USING_MCORE_DUMP_LATEST_VERSION'. This will cause the default value to never be applied.

Suggested change
default 0x99999 if PKG_USING_MCOREDUMP_LATEST_VERSION
default "latest" if PKG_USING_MCORE_DUMP_LATEST_VERSION
config PKG_MCOREDUMP_VER_NUM
hex
default 0x99999 if PKG_USING_MCORE_DUMP_LATEST_VERSION

Copilot uses AI. Check for mistakes.
@Rbb666 Rbb666 merged commit 96068bd into RT-Thread:master Aug 20, 2025
11 of 12 checks passed
@Rbb666 Rbb666 deleted the mlw-fx branch August 20, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant