fix: Visual Bug Fixes for Theme Selection #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MarlonPassos-git is attempting to deploy a commit to the sylartist's projects Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
Hi! The problem is that I need the custom ThemeContext for managing theme with the icons, but also within the kbar menu. Tried before with the hook from next, but it was'nt working and bugs were even worse than now. So if you have another solution, why not, but for now I won't replace my custom implementation, unless your solution works for both kbar (settings) and icons . But thank you for all your improvements and suggestions! |
Contributor
Author
|
ok, i'll take a look tonight |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There were several visual bugs when no theme was selected:
Video before corrections
After Corrections
Video after Corrections