forked from tensorflow/models
-
Notifications
You must be signed in to change notification settings - Fork 7
Mesh rcnn #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…els into mesh_rcnn_lintergit
Added first implementation for graphconv. The code was validated with a simple test on an undirected graph.
Implementation of graph conv with comprehensive testing completed.
…ed/padded representations of vertices and faces and implemented edge computation
…t run slower, but will be easier to debug in the future
Added gradient test and used pylint to fix formatting issues
This was done so the mesh sampler and the utility functions/class for getting the closest points in each point cloud can both live in mesh sample while providing a clear distinction between them.
Note: this is currently a prototype. A rationale for pushing this prototyping and the TODOs are listed in the module docstring.
Added class that encompases all of the mesh based loss terms (chamfer, normals, and edge) as well as voxel BCE loss. Added option to pass batch weights to chamfer and normal loss. Refactored some code for greater modularity.
TF implementation was applying point reduction before multiplying by weights when the original implementation was doing the opposite.
These tests now run faster and no longer assert values for functions that depend on other random functions (i.e. the mesh sampler).
Mesh R-CNN Mesh Losses
Fully unit tested (test_z_head.py) Weights loaded (test_load_weights.py) Differential tested (code not provided)
added config in mesh_rcnn.py Fixed fc layer weight initializer
Aligning function arguments to be in same column
test_z_head main function now says "tf.test.main()"
Add parameters to z-head test
Mesh rcnn zhead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
For a new feature or function, please create an issue first to discuss it
with us before submitting a pull request.
Note: Please delete options that are not relevant.
Tests
Test Configuration:
Checklist