这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@davidliii
Copy link
Collaborator

Description

Replaced dataset visualization code with test cases.

Type of change

For a new feature or function, please create an issue first to discuss it
with us before submitting a pull request.

Note: Please delete options that are not relevant.

  • A new research paper code implementation

Tests

📝 Please describe the tests that you ran to verify your changes.

  • The generator can be tested using by running python -m official.vision.beta.projects.mesh_rcnn.data.create_pix3d_tf_record_test

Test Configuration:
In create_pix3d_tf_record_test, ensure that pix3d_dir is set to the directory where the raw Pix3D dataset is located. A test annotation file is provided under official/vision/beta/projects/mesh_rcnn/data called tfrecord_pix3d_test_annotations.json. This file should be copied into the raw dataset directory.

Checklist

@davidliii davidliii requested a review from lenliu3 December 2, 2021 21:02
Copy link
Collaborator

@lenliu3 lenliu3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

official/vision/beta/projects/mesh_rcnn/data/create_pix3d_tf_record.py
line 17 - "r" character outside of docstring
line 76 - second conditional clause seems redundant

@lenliu3 lenliu3 merged commit 07accda into mesh_rcnn_tfrecord_gen_pix3d Dec 2, 2021
@lenliu3 lenliu3 deleted the mesh_rcnn_tfrecord_pix3d_test branch December 2, 2021 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants