这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@Praveenmail2him
Copy link
Owner

No description provided.

ardaguclu and others added 6 commits October 18, 2022 10:19
Initially, all project-listing errors were fatal.  bcf5470 (make oc
login tolerate kube with --token, 2016-09-27) began tolerating
IsNotFound.  40e76d0 (make login, project, and discovery work
against kube with RBAC enabled, 2016-10-12) began tolerating
IsForbidden.  But sometimes the error can be on the service side, like
[1]:

  $ oc login --token=...

  Logged into "https://api..." as "..." using the token provided.

  Error from server (Timeout): the server was unable to return a response in the time allotted, but may still be processing the request (get projects.project.openshift.io)

With this commit, we log the error, so the caller is aware that we had
problems, but we fall back to 'default', because it's hard to imagine
a situation where the caller would rather not be logged in.  If they
want to adjust their default project after logging in, they can always
do that in follow-up work.

[1]: https://issues.redhat.com/browse/OCPBUGS-2495
Removing `GIT_SSH=/dev/null` to allow using SSH based authentication.
OCPBUGS-2495: pkg/cli/login: Warn, but do not fail, on surprise project-list errors
Bug 2078694: New-App Using Git via SSH
Do not try to load plugins for cobra commands
@Praveenmail2him Praveenmail2him merged commit 5d67cf5 into Praveenmail2him:master Oct 21, 2022
@Praveenmail2him Praveenmail2him self-assigned this Oct 21, 2022
@Praveenmail2him Praveenmail2him added the documentation Improvements or additions to documentation label Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants