这是indexloc提供的服务，不要输入任何密码
Skip to content

doc(known-issues): Add caveat about layout/hyphenation of rotated text #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 3, 2023
Merged

doc(known-issues): Add caveat about layout/hyphenation of rotated text #60

merged 6 commits into from
Sep 3, 2023

Conversation

ja-he
Copy link
Contributor

@ja-he ja-he commented Sep 2, 2023

Per discussion in #59.

I figured I could make myself useful by writing down what I tried to find before filing the issue.

Feel free to edit this or suggest edits as you prefer them or reject the PR, just my quick idea for a bit of doc.

@ja-he ja-he marked this pull request as draft September 2, 2023 16:08
@ja-he ja-he force-pushed the doc-add-rotation-known-issue-in-readme branch from 113ae4e to 1306d32 Compare September 2, 2023 16:20
@ja-he ja-he marked this pull request as ready for review September 2, 2023 16:20
@ja-he
Copy link
Contributor Author

ja-he commented Sep 2, 2023

Sorry, realized that your box-suggestion was the way to go after all, so I wanted to add that as well.
Feel free to squash the commits (or tell me to squash them) as you see fit.

@PgBiel
Copy link
Owner

PgBiel commented Sep 3, 2023

Don't worry about the commits. :)

@PgBiel
Copy link
Owner

PgBiel commented Sep 3, 2023 •
edited
Loading

I think another possible workaround might be to use #place over the rotate so the text doesn't occupy any space at all, thus allowing for more flexibility. We could perhaps mention both approaches. (This should be tested first, though.)

@PgBiel
Copy link
Owner

PgBiel commented Sep 3, 2023

Other than that, your text is pretty good. Thanks!

@PgBiel PgBiel added the documentation Improvements or additions to documentation label Sep 3, 2023
@PgBiel PgBiel linked an issue Sep 3, 2023 that may be closed by this pull request
Rotating cell contents seems to calculate dimensions wrong #59
Closed
@ja-he
doc(known-issues): Add #place workaround option for rotated cell co…
b7eadb5 
…ntents

In my experience, the most common appearance for table headings (here as
row headings rather than column headings) is as centered. Thus I chose
to use the `center + horizon` example to explain the `#place`
workaround.
@ja-he
Copy link
Contributor Author

ja-he commented Sep 3, 2023 •
edited
Loading

I think another possible workaround might be to use #place over the rotate so the text doesn't occupy any space at all, thus allowing for more flexibility. We could perhaps mention both approaches. (This should be tested first, though.)

I got the result I wanted and also got with box and hyphenate:false via rowspanx(7, box(rotate(-90deg, [...]))) rowspanx(7, place(center + horizon, rotate(-90deg, [...]))) so I added that to the text. (edit: just realized I wrote cellx for some reason, don't think it matters for readability of the workaround)

Again, feel free to edit as you want.

@PgBiel PgBiel merged commit abffc5a into PgBiel:main Sep 3, 2023
@PgBiel
Copy link
Owner

PgBiel commented Sep 3, 2023

Thank you! :D

@ja-he ja-he deleted the doc-add-rotation-known-issue-in-readme branch September 4, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rotating cell contents seems to calculate dimensions wrong
2 participants
@ja-he @PgBiel