这是indexloc提供的服务,不要输入任何密码
Skip to content

Split source into multiple files #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 12, 2023
Merged

Split source into multiple files #45

merged 9 commits into from
Nov 12, 2023

Conversation

PgBiel
Copy link
Owner

@PgBiel PgBiel commented Aug 10, 2023

Closes #46

Should make the code easier to work with.

@PgBiel PgBiel added the enhancement New feature or request label Aug 10, 2023
@PgBiel PgBiel self-assigned this Aug 10, 2023
@PgBiel PgBiel changed the base branch from main to 0.1.0-dev August 10, 2023 14:02
@emilyyyylime
Copy link

Is this up to date?
I'm thinking of contributing and I'd much rather base my contributions off of this version

@PgBiel
Copy link
Owner Author

PgBiel commented Oct 11, 2023

@emilyyyylime not yet (it wasn't yet updated for 0.0.5). Feel free to ping me on the weekend and I might be able to find some time for it 👀

@emilyyyylime
Copy link

😅 I'll have to try and remember

@PgBiel PgBiel added this to the v0.1.0 milestone Nov 12, 2023
@PgBiel PgBiel marked this pull request as ready for review November 12, 2023 17:27
@PgBiel
Copy link
Owner Author

PgBiel commented Nov 12, 2023

Did some (unscientific) benchmarks, and seems like these changes do not slow down tablex compilation in any way (the time to compile tablex-test.typ was the same on main and on separation).

@PgBiel PgBiel merged commit 5a72674 into 0.1.0-dev Nov 12, 2023
@PgBiel PgBiel deleted the separation branch November 12, 2023 18:50
PgBiel added a commit that referenced this pull request Dec 17, 2023
* initial source splitting attempt

* add remaining tablex code sections

* add a zero before numbers in filenames

* add docs at the top of each source file

* remove numbers from the filenames

* src: update to tablex 0.0.5 and 0.0.6

* ran tests in typst 0.9.0

* expose is-tablex-... functions

* remove unneeded imports in tablex.typ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split source code into multiple files
2 participants