Switch to native tables' fit auto columns algorithm #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures maximum fairness by calculating the maximum fair share to shrink the smallest amount of columns possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures maximum fairness by calculating the maximum fair share in order to shrink the smallest amount of columns possible.
Should lead to generally better-looking tables with auto columns, with cells having more space.
It was considered to add an option to keep the old algorithm (a toggle
fit-auto-cols-algorithm: "greedy" | "fair", defaulting to"fair"(the new algorithm)), but that was decided against, since most tables should look largely the same after this change, and those which change should change for the better. (And one can always override the column sizes manually anyway.)Before:
After: