Completed Take Home Assessment #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added .gitignore, requirements.txt, and moved app files to ./app
- Added a tests folder and included initial test / sanity check.
- Created first endpoint for getting book metadata under /book/{book_id}
Created a data access layer for retrieve the global book library and manipulating the user library. Introduced tests for these functions to test_data.py Add modules and fixtures for mocking (pytest-mock)
Added remaining functionality for /book endpoint to API layer and service layer. Added tests for api layer to test_api.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is my completed submission for the take-home assessment.
A quick note on my approach: For Book metadata, I only provided the fields mentioned in TASK.md - Feature 5 (title, author, year, language, percentage, page num). The remaining fields (
link, language, image_link) are available on the Book model but removed at the time of response.