Fix resource calculation in map generator #21882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The editor's resource value calculation logic was fixed in OpenRA#21820 to match actual gameplay. The map generator logic originally copied the editor logic from EditorResourceLayer rather than ResourceLayer and associated game logic. As such, it inherited incorrect calculations. This change updates the map generator logic to match the now consistent logic in both ResourceLayer classes. Map generator resource settings are also adjusted -25% to continue roughly matching the previous resource output.
Contributor
Author
|
We could potentially consider merging the 3 implementation copies into one authoritative source, probably in ResourceLayer. I didn't feel it proportionate to refactor that deeply in this PR, however. |
PunkPun
approved these changes
Apr 30, 2025
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The editor's resource value calculation logic was fixed in #21820 to match actual gameplay. The map generator logic originally copied the editor logic from EditorResourceLayer rather than ResourceLayer and associated game logic. As such, it inherited incorrect calculations.
This change updates the map generator logic to match the now consistent logic in both ResourceLayer classes. Map generator resource settings are also adjusted -25% to continue roughly matching the previous resource output.