Fix tileset MiniYaml keys to be consistent with Ids #21700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the `Template@...` number consistent with the `Id: ...` (if any). The keys are ignored by the engine, so this has no behavioral change.
Contributor
Author
|
Initially found by accident. Searched for all occurrences with this hacky one-liner: $ paste <(grep -Po '(?<=\tTemplate\@)([1-9]|[0-9]{2,})(?=\:$)' mods/*/tilesets/*.yaml) <(grep -Poh '(?<=\t\tId: {0,9})([1-9]|[0-9]{2,})$' mods/*/tilesets/*.yaml) | tr ':' '\t' | awk '$2 != $3'
mods/cnc/tilesets/snow.yaml 188 189
mods/cnc/tilesets/snow.yaml 189 190
mods/cnc/tilesets/snow.yaml 190 191
mods/cnc/tilesets/snow.yaml 191 192
mods/cnc/tilesets/winter.yaml 188 189
mods/cnc/tilesets/winter.yaml 189 190
mods/cnc/tilesets/winter.yaml 190 191
mods/cnc/tilesets/winter.yaml 191 192 |
RoosterDragon
approved these changes
Jan 11, 2025
PunkPun
approved these changes
Jan 11, 2025
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the
Template@...number consistent with theId: ...(if any).The keys are ignored by the engine, so this has no behavioral change.