这是indexloc提供的服务，不要输入任何密码
Skip to content

Rename Fluent-related code to be more precise. #21602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 4, 2024
Merged

Rename Fluent-related code to be more precise. #21602

merged 3 commits into from
Oct 4, 2024

Conversation

@pchote
Copy link
Member

@pchote pchote commented Oct 1, 2024 •
edited
Loading

A spin off from active discussions on Discord: The term "translation" is used without restraint throughout the code and yaml to refer to many distinct concepts - many of which may be language related, but are not translation (i.e the ability to select between different languages) related.

This PR applies a brute-force rename in an attempt to define more precise terminology for language- and (specifically) fluent-related concepts/code to free up "translation" for the actual (future) translation implementation details.

This intentionally avoids changing the external API exposed to yaml and lua, these are left to followup PRs as they will contain logic changes in addition to just renaming.

@pchote pchote added this to the Next Release milestone Oct 1, 2024
@pchote pchote force-pushed the translation-to-fluent branch from 3c106d0 to 8cfcada Compare October 1, 2024 18:34
@pchote
Copy link
Member Author

pchote commented Oct 1, 2024

I'd be happy to rename FluentProvider etc to LanguageProvider if there is a consensus that would be a better fit.

@PunkPun
Copy link
Member

PunkPun commented Oct 2, 2024

I find FluentBundle.Arguments quite weird. I recon it should be moved to FluentProvider as this is the class all outside code should interface with

I'm fine with either LanguageProvider or FluentProvider

@pchote
Copy link
Member Author

pchote commented Oct 2, 2024

Removed FluentBundle.Arguments completely, which saves a dictionary allocation each time.

@anvilvapre
Copy link
Contributor

anvilvapre commented Oct 3, 2024

Something generic like StringBundle or ResourceBundle - as used in some languages - sounds better to me. As using the Fluent library is just an implementation detail.

@pchote
Copy link
Member Author

pchote commented Oct 3, 2024

I more or less agree, but they were already discussed and ruled out for FluentBundle etc on Discord.

@pchote pchote force-pushed the translation-to-fluent branch from 2874407 to 7a4706b Compare October 3, 2024 19:34
PunkPun
PunkPun approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't find any regressions

@PunkPun PunkPun merged commit 464e0dc into OpenRA:bleed Oct 4, 2024
3 checks passed
@PunkPun
Copy link
Member

PunkPun commented Oct 4, 2024

changelog

@pchote pchote deleted the translation-to-fluent branch October 4, 2024 19:51
@PunkPun PunkPun mentioned this pull request Oct 15, 2024
Merged
@pchote pchote mentioned this pull request Oct 15, 2024
Merged
@Mailaender
Copy link
Member

Mailaender commented Oct 20, 2024

I think this is actually more imprecise. @projectfluent is not about managing strings, but natural language translations. While this is just internal API and I like the more concise, params you didn't do the project any good with the renaming.

@Mailaender Mailaender mentioned this pull request Oct 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PunkPun PunkPun PunkPun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Release 20250330

Development

Successfully merging this pull request may close these issues.

4 participants

@pchote @PunkPun @anvilvapre @Mailaender