scheduler/printers.c: Add warning when loading printers #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelrsweet
requested changes
Nov 10, 2021
Member
michaelrsweet
left a comment
There was a problem hiding this comment.
So I'm ok in general with this, but I'd recommend just logging the general messages at the end and not the per-printer messages (or make those "debug" messages) in order to keep the extra logging to a minimum...
Since drivers and raw queues going are deprecated and going to be removed, this change will introduce a warning during cupsd's start. This way we have all print queue installation options covered - lpadmin and web ui were enhanced with warning in the past.
4cdc121 to
9b19d8b
Compare
Member
Author
|
I've changed the log level of per-queues messages to DEBUG. Thanks for the review! |
|
@zdohnal, this change causes the test suite to fail because two new warnings show up in the log: |
Member
Author
|
@atsampson thx, interesting that tests on PR didn't catch that... fixed by 2857cd8 . |
|
@zdohnal - that's fixed it - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since drivers and raw queues going are deprecated and going to be
removed, this change will introduce a warning during cupsd's start.
This way we have all print queue installation options covered - lpadmin
and web ui were enhanced with warning in the past.
With this one merged, I would proceed with rc release - I hope I'll manage it this week (to match 2 week candency)