cups-compiler.m4: Check for -fstack-protector-strong #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelrsweet
requested changes
Nov 10, 2021
Member
michaelrsweet
left a comment
There was a problem hiding this comment.
No problem with supporting the increased stack protection option, note in my comments that we have some old LSB cruft that can be removed...
@zdohnal Don't forget to run "autoconf -f" and commit the new configure script after this change is merged...
config-scripts/cups-compiler.m4
Outdated
Member
There was a problem hiding this comment.
I checked and we can drop the LSB_BUILD check - none of the other LSB options are left so this is "dead code"...
Member
Author
There was a problem hiding this comment.
Ok, thanks for the check! I'll remove it as well then.
GCC can provide even stronger stack protection, let's use it if available. Otherwise fall back to -fstack-protector.
19dcc73 to
46a4016
Compare
Member
Author
|
I should be fixed now, please recheck - I didn't remove any other LSB code there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC can provide even stronger stack protection, let's use it if
available. Otherwise fall back to -fstack-protector.
I found this during development on centos stream 9 - I wasn't able to pass -fstack-protector-strong (which is one of the reqs in centos stream 9/RHEL 9) into compiled libcups.so.2, then found out gcc chose more generic -fstack-protector because of configure check.