This repository was archived by the owner on Feb 16, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 216
Fix typos in READMEs #757
Merged
Merged
Fix typos in READMEs #757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachin-101
approved these changes
Dec 2, 2020
Contributor
sachin-101
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @wynot12
AmrMKayid
added a commit
that referenced
this pull request
Dec 15, 2020
* deployment-version-0.2: (61 commits) Bug Fix: Fix secret_manager string and missing parameter in routes Added argument parser to API Added DATABASE_URL env varialbe & Added pymysql as a dependency Added database info as env variables to deploy.sh Add load balancer DNS Fix: Update self=False in all security groups Added database security group to allow incoming connection from Pygrid app Added database in AWS Serverfull Fix database secret arn generation issue Fix `user_data` issue Add app counts for deploying multiple instances Add suggested changes Fix typos in READMEs (#757) Build `Load Balancer` for the instances Update output from instances cluster Creating cluster of instances Update API for `AWS Serverfull` Deployment Update CLI Finalize AWS Serverfull deployment sorting imports ...
AmrMKayid
pushed a commit
that referenced
this pull request
Dec 15, 2020
AmrMKayid
pushed a commit
that referenced
this pull request
Dec 19, 2020
IonesioJunior
pushed a commit
that referenced
this pull request
Jan 4, 2021
* Bug Fix: Fix secret_manager string and missing parameter in routes * PyGrid CLI (#709) * Initial CLI module * Write setup file for CLI * Create utils.py for CLI * Add click Colors * Basic CLI * Testing click.group, config and greeting user * Basic deploy command * Logging config to output file at the end * Update README.md Add CLI installation and basic usage to README * Fix installation command * Promt User for deployment information * Add basic node and network commands * Add simple method for coloring * Hide credentials inputs * Create aws.py for managing deployment on AWS * Create gcp.py for managing deployment on GCP * Create azure.py for managing deployment on AZURE * Get Providers Configuration Prompting user to provide configuration for the selected cloud * Update README.md * Using boto3 to get regions and instances types * Using PyInquirer for promting questions interactively * Printing provider configrations * Get PyGrid App Arguments for deployment * Update README.md * Terraform helper scripts * Create Provider super class * Using terrascript * GCP Provider class template * Azure Provider class template * base setup deployment script * AWS Provider class ✅ * Update CLI AWS serverfull deployment for both nodes and networks are done ✅ * Initial GCP deployment Needs promting user configs, adjusting configs dynamically, testing * Small updates * Replace deployment keys with credentials file * Create EC2 class for client config * Create GCloud class for using GCP CLI commands * Getting GCP User Config * Create AZ Class for using AZ CLI commands * Getting Azure User Config * Wrote Main Azure resources Note: Change from Azure => Azurem (need to wait for update from terrascript) * PyGrid Network & Node Deployment on Azure Need proper testing... * Update deploy base script * GCloud Deployment is READY ✅🎉 Co-authored-by: Patrick Cason <me@patrickcason.com> * add boto3 in setup.py for CLI (#735) * Merge branch 'infrastructure/api' into serverfull-api * Fixed bugs inroduced due to merging branches, Serverless deployment functional again * Moved to Config object in app.py * Fixed issues with cli config object * Fixed bugs inroduced due to merging branches, Serverless deployment functional again * Moved to Config object in app.py * Fixed issues with cli config object * Separated resources into functions * gives more modularity to adding/removing resources * Added outputs to AWS serverless * Fixed cidr_block generation issues for subnets * Used built in terraform function to generate the cidr_blocks * Rename `provider_utils` to `providers` * sorting imports * Finalize AWS Serverfull deployment * Update CLI * Update API for `AWS Serverfull` Deployment * Update README.md * Merge branch 'dev' into serverfull-api * Creating cluster of instances * Update output from instances cluster * Build `Load Balancer` for the instances * Add suggested changes * Comment out dev related stuff * simplify class variables in AWS_Serverless * Add app counts for deploying multiple instances * Fix typos in READMEs (#757) * Merge branch 'dev' into serverfull-api * Fix `user_data` issue - thanks for the help @sachin-101 * Fix database secret arn generation issue * Added database in AWS Serverfull * Added database security group to allow incoming connection from Pygrid app * It blocks any other ingress connection * Fix: Update self=False in all security groups * Added database info as env variables to deploy.sh * Add load balancer DNS * Merge branch 'serverfull-api' of https://github.com/OpenMined/PyGrid into serverfull-api * Added DATABASE_URL env varialbe & Added pymysql as a dependency * Added argument parser to API * Bug Fix: Fix secret_manager string and missing parameter in routes * Add missing files for infra * Rebasing on `pygrid_0.3.0` branch * Replace `Node` with Domain in infra code * Corrected setup.py to install CLI * Add instances info * getting arguments for multiple apps This is used when count > 1 * Building multiple instances based on user count Co-authored-by: sachin-101 <sachinkumar04428@gmail.com> Co-authored-by: Patrick Cason <me@patrickcason.com> Co-authored-by: Nilansh Rajput <2017csb1092@iitrpr.ac.in> Co-authored-by: Wooyeon Lee <wylee@apache.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix typos in README files
Affected Dependencies
None
How has this been tested?
None
Checklist