This repository was archived by the owner on Nov 7, 2023. It is now read-only.
Clean up VBOs when we remove actors. #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eventually, we will run out of Vertex Buffer Objects. Now, it is possible for the GPU to reuse them. Some sources cite that it is poor practice to allocated and deallocate VBOs (though much better than never deallocating them), and it would be better to maintain a reference to them and reuse them instead. Also, cache the depthBits parameter. Getting WebGL parameters takes some time, and if we know they haven't changed, we can cache the values to get a minor speed improvement.
Member
|
Thanks @manthey LGTM 👍 |
manthey
added a commit
that referenced
this pull request
Jan 4, 2016
Clean up VBOs when we remove actors.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eventually, we will run out of Vertex Buffer Objects. Now, it is possible for the GPU to reuse them. Some sources cite that it is poor practice to allocated and deallocate VBOs (though much better than never deallocating them), and it would be better to maintain a reference to them and reuse them instead.
Also, cache the depthBits parameter. Getting WebGL parameters takes some time, and if we know they haven't changed, we can cache the values to get a minor speed improvement.