这是indexloc提供的服务,不要输入任何密码
Skip to content
This repository was archived by the owner on Nov 7, 2023. It is now read-only.

Conversation

@manthey
Copy link
Contributor

@manthey manthey commented Feb 7, 2018

This resolves a security warning on GitHub. The new version of jQuery should do no harm (or give any benefit).

This resolves a security warning on GitHub.  The new version of jQuery
should do no harm (or give any benefit).
@manthey
Copy link
Contributor Author

manthey commented Feb 8, 2018

Since making this branch (on January 19, 2018) and making it a PR (on February 7), the build no longer works. This is because, through the jasmine/phantom test runner we use, we request jasmine and related sources via links like http://jasmine.github.io/2.0/lib/jasmine.js. These links return a 301 redirecting to the https variant. Switching the links to https somehow is not sufficient -- perhaps some other library needs to be upgraded. If I download the five files we reference from jasmine.github.io and refer to them locally, then the build succeeds.

@jbeezley Do you a simple way to fix this -- we aren't doing much to vgl, so I don't want to do a major tool shift if we can avoid it.

@jbeezley
Copy link

jbeezley commented Feb 8, 2018

I would vote for including the files in the repo.

Before, we pulled these from github from the test process, but the
mechanism we were using is no longer working, probably due to permanent
redirects to https.  Instead, have cmake get the files.
@manthey
Copy link
Contributor Author

manthey commented Feb 9, 2018

@jbeezley Better, I have cmake download the files. @aashish24 Since I made changes, you may want to check this again before I merge.

@manthey manthey merged commit 66ebfc2 into master Dec 18, 2018
@manthey manthey deleted the update-jquery branch December 18, 2018 15:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants