fix integration test for fixedincome controller #5060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaslek
approved these changes
May 23, 2023
| ameribor --help | ||
| fed -s 2022-01-01 -e 2023-01-01 | ||
| fed --parameter volume --target --quantiles | ||
| fed --help | ||
| iorb -s 2022-01-01 -e 2023-01-01 --export | ||
| iorb -s 2022-01-01 -e 2023-01-01 --export xlsx --sheet-name IORB |
There was a problem hiding this comment.
Thinking about all the integration tests, I'm scared to look at the exports on the computers lol
There was a problem hiding this comment.
I was having this same thought, only for the unit testing that captures the HTTP response and the parsed content, so it could really start to bloat the repo with test cassettes.
There was a problem hiding this comment.
Shall we create a cleanup.sh script to run at the end of integration tests?
There was a problem hiding this comment.
Probably. Or at least to run it weekly or something. These things have been running daily (or more) for months haha
IgorWounds
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to resolve this issue: