Remove stocks/disc/cnews command #4920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewpad Report
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #4920 +/- ##
===========================================
- Coverage 58.28% 58.27% -0.02%
===========================================
Files 588 588
Lines 53667 53633 -34
===========================================
- Hits 31280 31253 -27
+ Misses 22387 22380 -7
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug in the cnews (customized news) command was identified in the integration test logs.
The cnews command that scrapes a seekingalpha page now bumps into a capcha window and does not work any more.
This PR removes the command from the terminal, SDK, translations, default sources json, tests and intros section of the documentation.
I've updated the tests for the controller and the seeking aplha model and view
Note: there were a few duplicate fields in the default_sources.json that I've cleaned up
Question to @jose-donato: Will need to update the default sources section on the hub manually?