这是indexloc提供的服务,不要输入任何密码
Skip to content

Removes exchange option from stocks/load #4673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2023
Merged

Removes exchange option from stocks/load #4673

merged 2 commits into from
Apr 4, 2023

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Apr 3, 2023

Description

It looks like the yfinance does not work here, so there is no reason to provide a broken option.

@reviewpad reviewpad bot added the feat XS label Apr 3, 2023
Copy link
Contributor

@jmaslek jmaslek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aight

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@f3b74da). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #4673   +/-   ##
==========================================
  Coverage           ?   56.80%           
==========================================
  Files              ?      591           
  Lines              ?    53853           
  Branches           ?        0           
==========================================
  Hits               ?    30590           
  Misses             ?    23263           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmaslek jmaslek added this pull request to the merge queue Apr 4, 2023
Merged via the queue into develop with commit 5a8d6e8 Apr 4, 2023
jmaslek pushed a commit that referenced this pull request Apr 13, 2023
* Added fixes

* Added fixes
@piiq piiq deleted the hotfix/4587 branch April 24, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants