Add version featflag #4487
Merged
Add version featflag #4487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #4487 +/- ##
==========================================
Coverage ? 54.53%
==========================================
Files ? 596
Lines ? 53526
Branches ? 0
==========================================
Hits ? 29191
Misses ? 24335
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
jmaslek
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag is meant so that I can make screenshots for guides and similar without constantly needing to adjust the code. This removes the version in the bottom right corner.
The whole purpose of this is that because the terminal doesn't change everywhere all the time and images are there for illustration purposes. If it shows the version number it can confuse by assuming the whole documentation is outdated. We don't have the resources to have someone constantly update the docs in that manner.
E.g. we won't change Portfolio Optimisation and if we don't have this flag at some point it will have a very old version. Also relevant for presentations.