stocks/fa/analysis returns empty dataframe instead of error when no data #3858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaslek
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Quick and unsophisticated fix for Bug #3822
Now just checks if resulting list is empty and returns empty DataFrame. In the terminal, this will trigger printing a message (filings not found) and in SDK this will just return a blank DataFrame.
No error message appears in either case but if you'd prefer some sort of message in the notebook then please say!
How has this been tested?
Tested various US and non-US tickers (and some made up tickers).
stocks -> load coin -> fa -> analysisIn terminal:
In notebook:
As expected, COIN should not return results.
Apple, however, should run just fine...
stocks -> load aapl -> fa -> analysisIn terminal:
In notebook:
