这是indexloc提供的服务，不要输入任何密码
Skip to content

Adds historical end date on the ca menu #3867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 5, 2023
Merged

Adds historical end date on the ca menu #3867

merged 9 commits into from
Jan 5, 2023

Conversation

jmaslek
Copy link
Contributor

@jmaslek jmaslek commented Jan 3, 2023

This was asked for in #3835 and has been applied tp the terminal and the sdk. Note sdk usage:

Tests updated and this was added to all the yf calls in the menu.

Screenshot 2023-01-03 at 4 40 17 PM

@jmaslek jmaslek added the feat XS label Jan 3, 2023
@reviewpad reviewpad bot added feat M and removed feat XS labels Jan 3, 2023
@jmaslek jmaslek mentioned this pull request Jan 3, 2023
Closed
@montezdesousa
Copy link
Contributor

End date inputs before or equal to start date yield an error in the terminal for historical and volume commands. Seem ok for the sdk

Screenshot 2023-01-04 at 14 36 17

@jmaslek
Copy link
Contributor Author

jmaslek commented Jan 4, 2023

End date inputs before or equal to start date yield an error in the terminal for historical and volume commands. Seem ok for the sdk

Screenshot 2023-01-04 at 14 36 17

Adding a helper to check this:

2023 Jan 04, 10:29 (🦋) /stocks/ca/ $ volume --start 2022-01-01 --end 2022-01-01

Start date and end date cannot be the same.

2023 Jan 04, 10:29 (🦋) /stocks/ca/ $ volume --start 2022-01-01 --end 2021-01-01

Start date cannot be greater than end date.

@jmaslek jmaslek force-pushed the historical_end_date branch from 1fed9eb to 24c1ef3 Compare January 4, 2023 15:41
@reviewpad reviewpad bot added feat L and removed feat M labels Jan 4, 2023
hjoaquim
hjoaquim suggested changes Jan 5, 2023
View reviewed changes
@jmaslek jmaslek merged commit 93f440a into OpenBB-finance:main Jan 5, 2023
@jmaslek jmaslek deleted the historical_end_date branch January 5, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoaquim hjoaquim hjoaquim approved these changes

@montezdesousa montezdesousa Awaiting requested review from montezdesousa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmaslek @montezdesousa @hjoaquim