[BugFix] economy.calendar(provider='nasdaq'): Fix 'No record found' Error Raising Instead Of Returning
#7178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piiq
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the error detection logic of
obb.economy.calendar(provider="nadaq").A previous PR incorporated more robust error handling, and failed to anticipate the error for "No data found" while iterating over multiple dates. Instead of returning the data that does exist, it raised the error.
This PR fixes it by:
date.weekday() < 5The default start/end dates have been adjusted to be -2/+3 days from today.
As of today, this can be tested with the default settings:
obb.economy.calendar(provider="nasdaq")