这是indexloc提供的服务，不要输入任何密码
Skip to content

Changing jib behaviour to have current timestamp rather than start of Unix epoch as image creation time. #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 15, 2022
Merged

Changing jib behaviour to have current timestamp rather than start of Unix epoch as image creation time. #7

merged 2 commits into from
Jun 15, 2022

Conversation

@Sounie
Copy link
Contributor

@Sounie Sounie commented Jun 12, 2022

I've just tried building locally and found it confusing to see Docker indicating that the image was created 52 years ago.

So I did some digging and came across:
https://github.com/GoogleContainerTools/jib/blob/master/docs/faq.md#why-is-my-image-created-48-years-ago

I have a preference for the metadata indicating the actual image creation time.

If someone really wants to reproduce the build then presumably they could just specify the image's timestamp in place of USE_CURRENT_TIMESTAMP.

@OneCricketeer
Copy link
Owner

OneCricketeer commented Jun 14, 2022

While this doesn't really negatively affect the runtime image in any way, what is the use-case for viewing/having this value be updated to the build-time?

@Sounie
Copy link
Contributor Author

Sounie commented Jun 15, 2022 •
edited
Loading

When building locally or pulling down from Dockerhub, this is part of what I see if I run:

> docker image ls

REPOSITORY                                 TAG                    IMAGE ID       CREATED         SIZE
cricketeerone/apache-kafka-connect         3.2.0                  d5fa66afe65a   52 years ago    267MB
cricketeerone/apache-kafka-connect         latest                 d5fa66afe65a   52 years ago    267MB

So it's not something that shows up on the container registry, but just looks odd when interacting with it as an artifact that I want to try running.

If I am building it locally, it would be nice to be able to see at a glance that the latest image was built a few hours or minutes ago.

I don't have a really strong opinion on this, I just found it a bit confusing compared to other Docker builds that I have run (which probably also haven't involved jib).

OneCricketeer
OneCricketeer approved these changes Jun 15, 2022
View reviewed changes
Copy link
Owner

@OneCricketeer OneCricketeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, now that I've figured out how to write a working Github action #2 , this should be good to go

@OneCricketeer OneCricketeer merged commit 262d64e into OneCricketeer:master Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OneCricketeer OneCricketeer OneCricketeer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Sounie @OneCricketeer