这是indexloc提供的服务，不要输入任何密码
Skip to content

dump the version class on "composer dump-autoload" #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 18, 2019
Merged

dump the version class on "composer dump-autoload" #91

merged 3 commits into from
Jun 18, 2019

Conversation

@staabm
Copy link
Contributor

@staabm staabm commented Jun 18, 2019 •
edited
Loading

the Readme describes that you should use the --optimize flag when dumping the autoloader.

this package does not yet hook into the dumping of autoloader when composer dump-autoload is used.

this PR adds support for class regeneration on composer dump-autoload.
we need this, since we use composer install ... --no-scripts in the CI pipeline and want to dump the autoloader on its own.

@staabm
Copy link
Contributor Author

staabm commented Jun 18, 2019

in case you accept this "bugfix", would you mind merging it into a php7.0 compatible release (package-version 1.2.x)?

@Ocramius
Copy link
Owner

Ocramius commented Jun 18, 2019

@staabm only security releases for older releases

Ocramius
Ocramius approved these changes Jun 18, 2019
View reviewed changes
Copy link
Owner

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Ocramius Ocramius added this to the 1.5.0 milestone Jun 18, 2019
@Ocramius Ocramius self-assigned this Jun 18, 2019
@Ocramius
Copy link
Owner

Ocramius commented Jun 18, 2019 

FILE: test/PackageVersionsTest/InstallerTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 89 | ERROR | [x] Multi-line arrays must have a trailing comma after the last
    |       |     element.
    |       |     (SlevomatCodingStandard.Arrays.TrailingArrayComma.MissingTrailingComma)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

@staabm
Copy link
Contributor Author

staabm commented Jun 18, 2019

fix already committed. thx for the heads up.

@Ocramius
Copy link
Owner

Ocramius commented Jun 18, 2019

Last failures are due to #92 - merging here.

@Ocramius Ocramius merged commit 17c53e1 into Ocramius:master Jun 18, 2019
@Ocramius
Copy link
Owner

Ocramius commented Jun 18, 2019

Thanks @staabm!

@staabm staabm deleted the patch-1 branch June 18, 2019 14:28
This was referenced Jun 18, 2019
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels

enhancement

Projects

None yet

Milestone

1.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

@staabm @Ocramius