这是indexloc提供的服务，不要输入任何密码
Skip to content

Parse self.version in replaced packages #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2018
Merged

Parse self.version in replaced packages #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/PackageVersions/Installer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,12 @@ private static function getVersions(Locker $locker, RootPackageInterface $rootPa
}

foreach ($rootPackage->getReplaces() as $replace) {
yield $replace->getTarget() => $replace->getPrettyConstraint() . '@' . $rootPackage->getSourceReference();
$version = $replace->getPrettyConstraint();
if ($version === 'self.version') {
Copy link
Owner

@Ocramius Ocramius Feb 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there something other than self.version that we can add to the tests to demonstrate alternate outcomes? Or is this the only "special" version type in composer.json?

$version = $rootPackage->getPrettyVersion();
}

yield $replace->getTarget() => $version . '@' . $rootPackage->getSourceReference();
}

yield $rootPackage->getName() => $rootPackage->getPrettyVersion() . '@' . $rootPackage->getSourceReference();
Expand Down
8 changes: 4 additions & 4 deletions test/PackageVersionsTest/InstallerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ final class Versions
'foo/bar' => '1.2.3@abc123',
'baz/tab' => '4.5.6@def456',
'tar/taz' => '7.8.9@ghi789',
'some-replaced/package' => 'self.version@aaabbbcccddd',
'some-replaced/package' => '1.3.5@aaabbbcccddd',
'root/package' => '1.3.5@aaabbbcccddd',
);

Expand Down Expand Up @@ -268,7 +268,7 @@ final class Versions
'ocramius/package-versions' => '1.0.0@',
'foo/bar' => '1.2.3@abc123',
'baz/tab' => '4.5.6@def456',
'some-replaced/package' => 'self.version@aaabbbcccddd',
'some-replaced/package' => '1.3.5@aaabbbcccddd',
'root/package' => '1.3.5@aaabbbcccddd',
);

Expand Down Expand Up @@ -375,7 +375,7 @@ final class Versions
'ocramius/package-versions' => '1.0.0@',
'foo/bar' => '1.2.3@abc123',
'baz/tab' => '4.5.6@',
'some-replaced/package' => 'self.version@aaabbbcccddd',
'some-replaced/package' => '1.3.5@aaabbbcccddd',
'root/package' => '1.3.5@aaabbbcccddd',
);

Expand Down Expand Up @@ -774,7 +774,7 @@ final class Versions
const ROOT_PACKAGE_NAME = 'root/package';
const VERSIONS = array (
'ocramius/package-versions' => '1.0.0@',
'some-replaced/package' => 'self.version@aaabbbcccddd',
'some-replaced/package' => '1.3.5@aaabbbcccddd',
'root/package' => '1.3.5@aaabbbcccddd',
);

Expand Down