-
-
Notifications
You must be signed in to change notification settings - Fork 10
pre-shared key first attempt #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! I just have a few comments, and I'll compile & double-check myself, but looks good!
Are you intending also to add support for providing the generated key to a wireguard_asymmetric_key
resource?
@OJFord is there a chance to get my changes in and released in short term? |
Certainly, but are you also intending to add an optional psk attr to the existing resource? Or do you have a use-case where you want the PSK generated in terraform but then you're using it with a keypair not from this provider? (Curious what that is?) |
Sure I can add it. However I'm not so sure if this attribute makes that much sense. I'm also a bit puzzled about the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agh, yes right sorry I was thinking of the config document data source which is where it's actually used - and you have already added it there; thanks.
I'm also a bit puzzled about the bind property of wireguard_asymmetric_key. Can you please shed some light here?
That's a bit of a hack around the sort of issue described in hashicorp/terraform#8099 (heh, I'd forgotten I opened that! This wasn't the use-case when I did.) - basically it acts like triggers
for null_resource
; rolls the key if the value of bind
changes.
I think I needed it for my systemd-wireguard module.
Tests are failing just due to Thanks! |
Closing via 1a01f5f - many thanks! I've been having some trouble with goreleaser, but it'll be in v0.2.1 when I have that sorted. |
Thanks again for this @odise - sorry for the delay releasing, I got it sorted but meant & forgot to draw your attention to it. v0.2.1 is now available in the Terraform registry with the |
Pre-sharedkey implementation as discussed in #6.