这是indexloc提供的服务,不要输入任何密码
Skip to content
This repository was archived by the owner on Mar 4, 2021. It is now read-only.

Conversation

@jhowarth
Copy link

This allows edda and the unusedImageRule for Janitor Monkey to be enabled and disabled independently.

@cloudbees-pull-request-builder

SimianArmy-pull-requests #83 SUCCESS
This pull request looks good

@coryb
Copy link
Contributor

coryb commented Oct 9, 2013

Sorry if I am missing something. It doesn't look like this patch does really decouple Edda from unusedImageRule. If simianarmy.janitor.edda.enabled property is false then we will still throw the RuntimeException("Image Janitor only works when Edda is enabled."). Perhaps this patch is for the case where Edda is enabled but simianarmy.janitor.rule.unusedImageRule.enabled is false? The net result of that would be an ImageJanitor without any rules which does not seem useful.

-Cory

@jhowarth
Copy link
Author

@coryb

Maybe I used the wrong term here. When I went to use the Janitor Monkey, I enabled edda by setting simianarmy.janitor.edda.enabled to true, but when I ran the army, it complained Image Janitor only works when Edda is enabled.. I had to go read through the source code to figure out what was going on. This is more of a pull request to solve that problem.

Perhaps there would be a better way to solve this and make sure Janitor Monkey is not started up with no rules.

@coryb
Copy link
Contributor

coryb commented Nov 26, 2013

Sorry for the delay, finally processing the backlog. Merging now. Thanks!
-Cory

coryb added a commit that referenced this pull request Nov 26, 2013
Decouple edda and unusedImageRule checks for Janitor Monkey
@coryb coryb merged commit 2ff61d8 into Netflix:master Nov 26, 2013
@jhowarth jhowarth deleted the janitor_fix branch December 18, 2013 22:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants