This repository was archived by the owner on Mar 4, 2021. It is now read-only.
Trim boolean configuration before parsing #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boolean.parseBoolean() is strict with respects to whitespace. When following the install guide, I ended up with whitespace in my configuration. "True " was parsed as false. Rather than fix the configuration instructions, it is much easier and more friendly to simply trim the value before parsing it, i.e. be tolerant in what we accept.
|
SimianArmy-pull-requests #42 SUCCESS |
coryb
added a commit
that referenced
this pull request
Sep 13, 2013
Trim boolean configuration before parsing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boolean.parseBoolean() is strict with respects to whitespace. When following the install guide, I ended up with whitespace in my configuration. "True " was parsed as false.
Rather than fix the configuration instructions, it is much easier and more friendly to simply trim the value before parsing it, i.e. be tolerant in what we accept.