This repository was archived by the owner on Mar 4, 2021. It is now read-only.
Conformity Check on Virtual Private Cloud Membership and add concept of cluster with instances not in an ASG #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a cluster which contains all the instances in a region - Added a Rule to check if instances are in the Virtual Private Cloud
… the instances collection.
|
SimianArmy-pull-requests #31 SUCCESS |
Contributor
There was a problem hiding this comment.
autoScalingGroups should be soloInstances
Contributor
|
Generally looks good, a small typo. |
- in response to pull request comment
Contributor
Author
|
Hi Michael Thanks for the feedback, we've made the changes as requested. Yeah a typo on my part :$ Dip |
Contributor
|
Looks good. Thanks. |
michaelnflx
added a commit
that referenced
this pull request
Jul 20, 2013
Conformity Check on Virtual Private Cloud Membership and add concept of cluster with instances not in an ASG
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
We have a requirement here at the BBC to check whether instances outside of an auto-scaling group conform to various rules. We also need to check specifically that they are in a Virtual Private Cloud (VPC).
I have created a new rule to check for VPC ID which hopefully will be OK. Additionally we have introduced the concept of a 'SoloInstance' Cluster which is created if any instances exist that are not part of an ASG.
I will make the necessary change to the wiki guide but before I do so I 'd like to check if the patch is valid and if not suggestions as to an approach to capture those instances outside of an ASG would be appreciated.
Thanks
Dip