This repository was archived by the owner on Mar 4, 2021. It is now read-only.
Conformity Monkey Simple DB tracker needs to quote domain name. #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple DB domain name needs to be escaped in the conformity monkey tracker class in case it contains characters such as '-'.
|
SimianArmy-pull-requests #29 SUCCESS |
Contributor
|
Looks good. |
michaelnflx
added a commit
that referenced
this pull request
Jul 5, 2013
Conformity Monkey Simple DB tracker needs to quote domain name.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The simple DB configured could contain characters such as '-'. This could lead to problems in the select query within the simple DB tracker class when performing select queries unless the domain name is properly quoted with back ticks.
Thanks
Dip