This repository was archived by the owner on Mar 4, 2021. It is now read-only.
Changes for Netflix environment compatibility #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…set force delete instances=true when deleting ASGs, don't set MediaType on JanitorMonkeyResource
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three changes for Netflix environment compatibility:
The first change is straightforward, AWS client update.
For the second change, if Janitor already made the decision to delete the ASG then there is no reason to keep the instances. Feedback welcome if anyone feels this is too aggressive.
The third change exposes a fundamental problem with JanitorMonkeyResource. Technically the return type should be JSON as it is a REST API but some routines return HTML! There probably should be separate APIs for JSON vs. HTML returns. But for now we are removing the explicit JSON return type on the JanitorMonkeyResource as it breaks our internal apps that are expecting HTML.