This repository was archived by the owner on Mar 4, 2021. It is now read-only.
updating Resources to have application/json content-type #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM, thanks for the contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this resource returns a JSON Array, let's set the Content-Type to the appropriate thing. Currently callers of this API are seeing a content-type of text/plain which technically is true, but for ease of integration and automated tools it should be set to reflect we are returning JSON in the body so "application/json" would be more accurate.
I also went beyond the original Issue #260 I created and am proposing to update the JanitorMonkeyResource in addition to the ChaosMonkeyResource.
Addresses Issue #260