这是indexloc提供的服务,不要输入任何密码
Skip to content
This repository was archived by the owner on Mar 4, 2021. It is now read-only.

Conversation

@mlafeldt
Copy link
Contributor

@mlafeldt mlafeldt commented May 9, 2016

In addition to the other monkeys.

@mlafeldt
Copy link
Contributor Author

mlafeldt commented May 9, 2016

PTAL.

Related question: why does the Simian Army start/stop all the monkeys, even if they're disabled via properties? I found this to be a bit confusing when first using the app, especially since the scheduler keeps logging that it's not time for monkey X even though X has been disabled.

@ebukoski
Copy link
Contributor

ebukoski commented May 9, 2016

That is a good question, I've wondered that myself. I would agree that if a monkey is disabled it would be better to not see any messages from it.

My theory about why they are started/stopped even if disabled: internally at Netflix the properties class is replaced with a Netflix internal realtime distributed property system. It gives us the ability to change any property from a central location and have the changes reflected in real time in any app including SimianArmy. So in theory we could enable/disable a monkey instantly with a property change but it would only work if the Monkey was enabled/started in the first place. However in reality we never do this so it is a purely theoretical capability.

@ebukoski
Copy link
Contributor

ebukoski commented May 9, 2016

PR LGTM thanks for the contribution!

@ebukoski ebukoski merged commit 1aaaa6d into Netflix:master May 9, 2016
@mlafeldt mlafeldt deleted the stop-conformity-monkey branch May 9, 2016 21:34
@mlafeldt
Copy link
Contributor Author

mlafeldt commented May 9, 2016

internally at Netflix the properties class is replaced with a Netflix internal realtime distributed property system

@ebukoski OK, in that context the code makes sense. Thanks for the detailed explanation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants